Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the disabled tests in the System V struct passing tests when Issue #2075 is resolved #4680

Closed
Tracked by #63902
LLITCHEV opened this issue Nov 17, 2015 · 5 comments · Fixed by #79742
Closed
Tracked by #63902

Fix the disabled tests in the System V struct passing tests when Issue #2075 is resolved #4680

LLITCHEV opened this issue Nov 17, 2015 · 5 comments · Fixed by #79742
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI good first issue Issue should be easy to implement, good for first-time contributors JitUntriaged CLR JIT issues needing additional triage test-bug Problem in test source code (most likely)
Milestone
Future

Comments

@LLITCHEV
Copy link
Contributor

Once the issue #4679 is resolved enable the commented out tests in System V bringup tests in JIT/Methodical/structs and make them test the right thing.

category:correctness
theme:testing
skill-level:beginner
cost:small
@LLITCHEV LLITCHEV self-assigned this Nov 17, 2015
@LLITCHEV
Copy link
Contributor Author

@joshfree This tracks enabling the tests after the issue #4679 is resolved. These two go hand in hand. If this issue is to be resolved by RC2 so should be issue #4679.

@joshfree
Copy link
Member

@LLITCHEV ok

@RussKeldorph
Copy link
Contributor

#4679 was pushed out to Future. Doing the same with this issue.

@yizhang82 @joshfree @LLITCHEV FYI.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 30, 2020
@msftgits msftgits added this to the Future milestone Jan 30, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@jkoritzinsky
Copy link
Member

Closing as #4679 was also closed

@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2021
@ericstj
Copy link
Member

ericstj commented Jan 21, 2022 •
edited
Loading

Reactivating to delete these test:

runtime/src/tests/JIT/Methodical/structs/systemvbringup/structpinvoketests.cs

Lines 171 to 187 in f04a242

public long w;
}
/* These tests are not working on non Windows CoreCLR. Enable this when https://github.com/dotnet/runtime/issues/4680 is resolved.
[StructLayout(LayoutKind.Sequential)]
public struct S28
{
public object x;
public int y;
}
[StructLayout(LayoutKind.Sequential)]
public struct S29
{
public int x;
public object y;
}
Enable this when https://github.com/dotnet/runtime/issues/4680 is resolved. */

(and many others in the same file)

@ericstj ericstj reopened this Jan 21, 2022
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Dec 16, 2022
@jakobbotsch
(Re)enable some SysV pinvoke tests
9ed90b8 
Fix dotnet#4680
jakobbotsch added a commit that referenced this issue Dec 17, 2022
@jakobbotsch
Delete some commented tests (#79742)
c90a2e8 
* (Re)enable some SysV pinvoke tests

Fix #4680

* Delete tests instead
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI good first issue Issue should be easy to implement, good for first-time contributors JitUntriaged CLR JIT issues needing additional triage test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Delete some commented tests jakobbotsch/runtime
7 participants
@joshfree @jkoritzinsky @ericstj @msftgits @LLITCHEV @BruceForstall @RussKeldorph