Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Assertion failed 'newLayoutCost < currLayoutCost' during 'Optimize layout' in libraries-jitstress #109831

Closed
amanasifkhalid opened this issue Nov 14, 2024 · 1 comment · Fixed by #109835
Closed

JIT: Assertion failed 'newLayoutCost < currLayoutCost' during 'Optimize layout' in libraries-jitstress #109831

amanasifkhalid opened this issue Nov 14, 2024 · 1 comment · Fixed by #109835
Assignees
@amanasifkhalid
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@amanasifkhalid
Copy link
Member

Example run. Introduced by #109741. cc @dotnet/jit-contrib
@amanasifkhalid amanasifkhalid added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 14, 2024
@amanasifkhalid amanasifkhalid added this to the 10.0.0 milestone Nov 14, 2024
@amanasifkhalid amanasifkhalid self-assigned this Nov 14, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid mentioned this issue Nov 14, 2024
Merged
@amanasifkhalid amanasifkhalid added the blocking-clean-ci-optional Blocking optional rolling runs label Nov 14, 2024
@amanasifkhalid amanasifkhalid mentioned this issue Nov 14, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 14, 2024
This was referenced Nov 18, 2024
Closed
Closed
@amanasifkhalid amanasifkhalid mentioned this issue Nov 19, 2024
Closed
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this issue Dec 10, 2024
@amanasifkhalid @mikelle-rogers
JIT: Relax cost improvement assert in 3-opt layout (dotnet#109835)
1340064 
Follow-up to dotnet#109741. Fixes dotnet#109831. Fixes dotnet#109905. Fixes dotnet#109903.

Tolerate some floating-point imprecision when comparing the cost of a new layout produced by 3-opt to the previous layout's cost. The JitStress failures I looked all stressed JitOptRepeat, which can produce absurdly large loop block weights by rerunning optSetBlockWeights. Manually inspecting the layout decisions made for these methods shows 3-opt making reasonable transformations, but the assertion newLayoutCost < currLayoutCost fails due to imprecision from summing large block weights. Having a backup check that the layout costs are within some epsilon seems like a reasonable fix.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Relax cost improvement assert in 3-opt layout amanasifkhalid/runtime
1 participant
@amanasifkhalid