-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Consolidate setret handling for diverging functions (#53535)
Some functions never associate the mini IR source registers used with their `setret` instructions with LLVM values because they unconditionally throw. `System.Runtime.Intrinsics.X86.Aes:Decrypt` is an example of such a function; when compiled for arm64, it never returns a value and unconditionally throws a `PlatformNotSupportedException`. We already had support for handling this for some, but not all, return value passing conventions. Deduplicate this support and apply it uniformly to all return value passing conventions that expect a populated mini IR source register. Make `LLVMArgNone` specifically mean "no return value"/"`void` return type". Split from #53132. Partially fixes FullAOT compilation of System.Private.CoreLib.dll on arm64.
- Loading branch information
Showing
3 changed files
with
64 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters