Fix exception thrown from MsQuicStream writes when connection is abor…

…ted by peer. (#67651) * Fix exception thrown from MsQuicStream writes when connection is aborted by peer. * Code review feedback
dotnet · Apr 8, 2022 · dee2bb5 · dee2bb5
1 parent 3e5e118
commit dee2bb5
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs b/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
@@ -1292,8 +1292,16 @@ private static uint HandleEventSendComplete(State state, ref StreamEvent evt)
                 }
                 else
                 {
+                    //
+                    // There are multiple reasons the send could have been cancelled:
+                    //   - Connection was aborted (either by transport or peer) => error-code already provided on the connection-level event
+                    //   - Stream's receive side was aborted by peer => already handled by HandleEventPeerRecvAborted
+                    //     and we will not set the exception due to complete == false
+                    //   - Stream's send side was aborted locally => no connection-level abort code and we return QuicOperationAbortException
+                    //
                     state.SendResettableCompletionSource.CompleteException(
-                        ExceptionDispatchInfo.SetCurrentStackTrace(new OperationCanceledException("Write was canceled")));
+                        ExceptionDispatchInfo.SetCurrentStackTrace(
+                            ThrowHelper.GetConnectionAbortedException(state.ConnectionState.AbortErrorCode)));
                 }
             }