Remove unnecessary taking ofthis as argument

dotnet · Jan 4, 2025 · 91a5fc2 · 91a5fc2 · xtqqczze · Jan 4, 2025
1 parent b33f755
commit 91a5fc2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/src/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultHtmlEncoder.cs b/src/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultHtmlEncoder.cs
@@ -88,16 +88,14 @@ internal override int EncodeUtf8(Rune value, Span<byte> destination)
                 }
                 else
                 {
-                    return TryEncodeScalarAsHex(this, (uint)value.Value, destination);
+                    return TryEncodeScalarAsHex((uint)value.Value, destination);
                 }
 
             OutOfSpace:
 
                 return -1;
 
-#pragma warning disable IDE0060 // 'this' taken explicitly to avoid argument shuffling by caller
-                static int TryEncodeScalarAsHex(object @this, uint scalarValue, Span<byte> destination)
-#pragma warning restore IDE0060
+                static int TryEncodeScalarAsHex(uint scalarValue, Span<byte> destination)
                 {
                     UnicodeDebug.AssertIsValidScalar(scalarValue);
 
@@ -154,16 +152,14 @@ internal override int EncodeUtf16(Rune value, Span<char> destination)
                 }
                 else
                 {
-                    return TryEncodeScalarAsHex(this, (uint)value.Value, destination);
+                    return TryEncodeScalarAsHex((uint)value.Value, destination);
                 }
 
             OutOfSpace:
 
                 return -1;
 
-#pragma warning disable IDE0060 // 'this' taken explicitly to avoid argument shuffling by caller
-                static int TryEncodeScalarAsHex(object @this, uint scalarValue, Span<char> destination)
-#pragma warning restore IDE0060
+                static int TryEncodeScalarAsHex(uint scalarValue, Span<char> destination)
                 {
                     UnicodeDebug.AssertIsValidScalar(scalarValue);
 

diff --git a/...aries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoder.cs b/...aries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoder.cs
@@ -123,11 +123,9 @@ internal override int EncodeUtf8(Rune value, Span<byte> destination)
                     return -1;
                 }
 
-                return TryEncodeScalarAsHex(this, value, destination);
+                return TryEncodeScalarAsHex(value, destination);
 
-#pragma warning disable IDE0060 // 'this' taken explicitly to avoid argument shuffling by caller
-                static int TryEncodeScalarAsHex(object @this, Rune value, Span<byte> destination)
-#pragma warning restore IDE0060
+                static int TryEncodeScalarAsHex(Rune value, Span<byte> destination)
                 {
                     if (value.IsBmp)
                     {
@@ -174,11 +172,9 @@ internal override int EncodeUtf16(Rune value, Span<char> destination)
                     return -1;
                 }
 
-                return TryEncodeScalarAsHex(this, value, destination);
+                return TryEncodeScalarAsHex(value, destination);
 
-#pragma warning disable IDE0060 // 'this' taken explicitly to avoid argument shuffling by caller
-                static int TryEncodeScalarAsHex(object @this, Rune value, Span<char> destination)
-#pragma warning restore IDE0060
+                static int TryEncodeScalarAsHex(Rune value, Span<char> destination)
                 {
                     if (value.IsBmp)
                     {