Address PR feedback

dotnet · Nov 22, 2020 · 8fe2a9b · 8fe2a9b
1 parent 43dbe24
commit 8fe2a9b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FreeEnvironmentStrings.cs b/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FreeEnvironmentStrings.cs
@@ -8,6 +8,6 @@ internal static partial class Interop
     internal static partial class Kernel32
     {
         [DllImport(Libraries.Kernel32, ExactSpelling = true)]
-        internal static extern unsafe int FreeEnvironmentStringsW(char* lpszEnvironmentBlock);
+        internal static extern unsafe BOOL FreeEnvironmentStringsW(char* lpszEnvironmentBlock);
     }
 }
diff --git a/src/libraries/System.Private.CoreLib/src/System/Environment.Variables.Windows.cs b/src/libraries/System.Private.CoreLib/src/System/Environment.Variables.Windows.cs
@@ -104,7 +104,7 @@ public static unsafe IDictionary GetEnvironmentVariables()
                         {
                             // Add may throw if the environment block was corrupted leading to duplicate entries.
                             // We allow such throws and eat them (rather than proactively checking for duplication)
-                            // to as to provide a non-fatal notification about the corruption.
+                            // to provide a non-fatal notification about the corruption.
                             results.Add(key, value);
                         }
                         catch (ArgumentException) { }
@@ -118,8 +118,8 @@ public static unsafe IDictionary GetEnvironmentVariables()
             }
             finally
             {
-                int success = Interop.Kernel32.FreeEnvironmentStringsW(stringPtr);
-                Debug.Assert(success != 0);
+                Interop.BOOL success = Interop.Kernel32.FreeEnvironmentStringsW(stringPtr);
+                Debug.Assert(success != Interop.BOOL.FALSE);
             }
         }
     }