Skip to content

Commit

Permalink
HttpStress: also disable firewall for HTTP2 (#52643)
Browse files Browse the repository at this point in the history
We decided that we need to rule out the Windows Firewall as a cause for further failure types documented in #42211.
  • Loading branch information
antonfirsov committed May 18, 2021
1 parent 610f34e commit 8fb2eb5
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions eng/pipelines/libraries/stress/http.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ jobs:
name: buildStress
displayName: Build HttpStress
# Firewall is disabled for the test runs, since it can lead to unexpected TCP failures on CI machines, which are unrelated to the HTTP logic.
# See: https://github.com/dotnet/runtime/issues/50854
- powershell: |
Set-NetFirewallProfile -Profile Domain, Public, Private -Enabled False
name: disableFirewall
displayName: Disable Firewall
- powershell: |
cd '$(httpStressProject)'
$env:HTTPSTRESS_CLIENT_ARGS = "$env:HTTPSTRESS_CLIENT_ARGS -http 2.0"
Expand All @@ -96,13 +103,6 @@ jobs:
displayName: Run HttpStress - HTTP 2.0
condition: and(eq(variables['buildRuntime.succeeded'], 'true'), eq(variables['buildStress.succeeded'], 'true'))
# Firewall is disabled for HTTP 1.1 runs.
# See: https://github.com/dotnet/runtime/issues/50854
- powershell: |
Set-NetFirewallProfile -Profile Domain, Public, Private -Enabled False
name: disableFirewall
displayName: Disable Firewall
- powershell: |
cd '$(httpStressProject)'
$env:HTTPSTRESS_CLIENT_ARGS = "$env:HTTPSTRESS_CLIENT_ARGS -http 1.1"
Expand Down

0 comments on commit 8fb2eb5

Please sign in to comment.