Skip to content

Commit

Permalink
[iOS] Use different tvOS helix queue for PR's (#72467)
Browse files Browse the repository at this point in the history
Up until now, we have used a single tvOS queue for all pipelines. This has lead to frequent timeouts because there simply aren't enough devices to handle spikes in traffic. We will now make use of two queues, one for runtime (PR's) and one for runtime-extra-platforms (scheduled jobs, manual runs). Since we are only running System.Runtime tests on PR's, we should see PR timeouts much less.
  • Loading branch information
steveisok committed Jul 20, 2022
1 parent 4545c45 commit 58efb7e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 5 additions & 1 deletion eng/pipelines/libraries/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ jobs:

# tvOS devices
- ${{ if in(parameters.platform, 'tvOS_arm64') }}:
- OSX.1015.Amd64.AppleTV.Open
# split traffic for PR's and rolling builds
- ${{ if ne(parameters.jobParameters.isExtraPlatforms, true) }}:
- OSX.1015.Amd64.AppleTV.Open
- ${{ if eq(parameters.jobParameters.isExtraPlatforms, true) }}:
- OSX.1100.Amd64.AppleTV.Open

# windows x64
- ${{ if eq(parameters.platform, 'windows_x64') }}:
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/runtime-extra-platforms-other.yml
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ jobs:
jobParameters:
testGroup: innerloop
nameSuffix: AllSubsets_Mono
isExtraPlatforms: ${{ parameters.isExtraPlatformsBuild }}
buildArgs: -s mono+libs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=true $(_runSmokeTestsOnlyArg) /p:BuildTestsOnHelix=true /p:EnableAdditionalTimezoneChecks=true /p:UsePortableRuntimePack=true /p:BuildDarwinFrameworks=true
timeoutInMinutes: 180
condition: >-
Expand Down

0 comments on commit 58efb7e

Please sign in to comment.