Skip to content

Commit

Permalink
Remove ValidateAssemblyVersionsInRefPack target
Browse files Browse the repository at this point in the history
The only thing this target did was a redundant check that AssemblyVersion was
set for projects in the Targeting Pack.  That check was failing for
the NETStandard build of System.DirectoryServices.

This target was providing no value, instead we need to fix #42961
which will be a proper check of our servicing version rules.
  • Loading branch information
ericstj committed Apr 4, 2023
1 parent 958f4ff commit 09dd019
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions eng/packaging.targets
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,6 @@
</ItemGroup>
</Target>

<Target Name="ValidateAssemblyVersionsInRefPack"
Condition="'$(SkipValidateAssemblyVersion)' != 'true' and '$(_AssemblyInTargetingPack)' == 'true' and '$(PreReleaseVersionLabel)' == 'servicing'"
AfterTargets="CoreCompile" >
<Error Condition="'$(AssemblyVersion)' != '$(LastReleasedStableAssemblyVersion)'" Text="AssemblyVersion should match last released assembly version $(LastReleasedStableAssemblyVersion)" />
</Target>

<Target Name="ValidateServicingVersionIsProperlySet"
Condition="'$(PreReleaseVersionLabel)' == 'servicing' and
'$(PackageUseIncrementalServicingVersion)' == 'true' and
Expand Down

0 comments on commit 09dd019

Please sign in to comment.