Optimizations related to directives (#1318)

dotnet · Dec 3, 2023 · e213afa · e213afa
1 parent eb5e546
commit e213afa
Showing 1 changed file with 25 additions and 6 deletions.
diff --git a/src/Core/Extensions/SyntaxExtensions.cs b/src/Core/Extensions/SyntaxExtensions.cs
@@ -670,8 +670,8 @@ public static bool SpanContainsDirectives(this SyntaxNode node)
             throw new ArgumentNullException(nameof(node));
 
         return node.ContainsDirectives
-            && !node.GetLeadingTrivia().Any(f => f.IsDirective)
-            && !node.GetTrailingTrivia().Any(f => f.IsDirective);
+            && !node.GetLeadingTrivia().ContainsDirective()
+            && !node.GetTrailingTrivia().ContainsDirective();
     }
 
     internal static bool SpanOrLeadingTriviaContainsDirectives(this SyntaxNode node)
@@ -680,7 +680,7 @@ internal static bool SpanOrLeadingTriviaContainsDirectives(this SyntaxNode node)
             throw new ArgumentNullException(nameof(node));
 
         return node.ContainsDirectives
-            && !node.GetTrailingTrivia().Any(f => f.IsDirective);
+            && !node.GetTrailingTrivia().ContainsDirective();
     }
 
     internal static bool SpanOrTrailingTriviaContainsDirectives(this SyntaxNode node)
@@ -689,7 +689,7 @@ internal static bool SpanOrTrailingTriviaContainsDirectives(this SyntaxNode node
             throw new ArgumentNullException(nameof(node));
 
         return node.ContainsDirectives
-            && !node.GetLeadingTrivia().Any(f => f.IsDirective);
+            && !node.GetLeadingTrivia().ContainsDirective();
     }
 
     /// <summary>
@@ -702,8 +702,16 @@ public static bool ContainsDirectives(this SyntaxNode node, TextSpan span)
         if (node is null)
             throw new ArgumentNullException(nameof(node));
 
-        return node.ContainsDirectives
-            && node.DescendantTrivia(span).Any(f => f.IsDirective);
+        if (node.ContainsDirectives)
+        {
+            foreach (SyntaxTrivia trivia in node.DescendantTrivia(span))
+            {
+                if (trivia.IsDirective)
+                    return true;
+            }
+        }
+
+        return false;
     }
 
     /// <summary>
@@ -1434,5 +1442,16 @@ public static int IndexOf(this SyntaxTriviaList triviaList, Func<SyntaxTrivia, b
 
         return -1;
     }
+
+    internal static bool ContainsDirective(this SyntaxTriviaList triviaList)
+    {
+        foreach (SyntaxTrivia trivia in triviaList)
+        {
+            if (trivia.IsDirective)
+                return true;
+        }
+
+        return false;
+    }
     #endregion SyntaxTriviaList
 }