Wait until solution load before we kick off all our nuget work. #9663
Conversation
CyrusNajmabadi
force-pushed
the
nugetBackoffMaster
branch
from
c536146
to
24a0874
Compare
|
Tagging @dotnet/roslyn-ide @jasonmalinowski @heejaechang |
|
retest vsi please |
| @@ -161,6 +166,14 @@ private void LoadComponents() | |||
|
|
|||
| LoadAnalyzerNodeComponents(); | |||
|
|
|||
| // Ensure the nuget package services are initialized after we've loaded | |||
There was a problem hiding this comment.
new MEF import will be also perf impacting thing for solution open.
There was a problem hiding this comment.
ah, sorry, git collapsed region and it looked like code belong to initialize.
if possible, importing and running from background thread will be even better.
|
👍 |
| // Start the whole process once we're connected | ||
| _installerService.PackageSourcesChanged += OnPackageSourcesChanged; | ||
| OnPackageSourcesChanged(this, EventArgs.Empty); | ||
| _started = true; |
There was a problem hiding this comment.
Should this happen before the call to OnPackageSourcesChanged in case anything in that method looks at it?
There was a problem hiding this comment.
actually, i just realized this isn't even necessary.
There was a problem hiding this comment.
Nope. Scratch that. Still necessary.
This boolean is just so we know if we've actually done the event hookup. That way we know if we should disconnect on 'Stop' down below. Where it comes here shouldn't really matter.
|
👍 |
|
Any reason not to get conflicts dealt with and merge this? |
|
Yup. I'll take care of this PR. |
|
test vsi please |
CyrusNajmabadi
changed the title
No description provided.