Realize less of the syntax tree during AbstractSemanticModelReuseLanguageService.GetPreviousBodyNode #77032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eLanguageService.GetPreviousBodyNode This is in a draft PR while speedometer tests determine if this has the desired effect. During the typing scenario in the scrolling speedometer test, about 13% of allocations are under GetPreviousBodyNode, due to realizing a bunch of nodes in the syntax tree to attempt to map from a method node in one tree to the corresponding node in similarly structured tree. Instead, as we know the trees have similar structure, just walk up the ancestors in the current tree to generate a node index path, and apply that path to the previous tree to find the appropriate method node.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
src/Workspaces/Core/Portable/SemanticModelReuse/AbstractSemanticModelReuseLanguageService.cs
Outdated
Show resolved
Hide resolved
|
VS test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/608266 Results look surprisingly good, going to raise out of draft status. Allocations under AbstractSemanticModelReuseLanguageService.GetPreviousBodyNode went from ~13% to 0.3%, with basically only the ClassDeclarationSyntax type allocations remaining under that stack. |
ToddGrun
changed the title
CyrusNajmabadi
approved these changes
Feb 5, 2025
src/Workspaces/Core/Portable/SemanticModelReuse/AbstractSemanticModelReuseLanguageService.cs
Show resolved
Hide resolved
…'t obviously different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the typing scenario in the scrolling speedometer test, about 13% of allocations in VS are under GetPreviousBodyNode, due to realizing a bunch of nodes in the syntax tree to attempt to map from a method node in one tree to the corresponding node in similarly structured tree. Instead, as we know the trees have similar structure, just walk up the ancestors in the current tree to generate a node index path, and apply that path to the previous tree to find the appropriate method node.
*** Without change ***
13% of VS allocations during typing:
Types allocated under GetPreviousBodyNode:
*** With change ***
0.3% of VS allocations during typing:
Types allocated under GetPreviousBodyNode:
