Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move async utils to Microsoft.CodeAnalysis.Threading source package #76937

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 27, 2025

Initial set of changes to move some async utility types to Microsoft.CodeAnalysis.Threading source package that can be reused across multiple repos (including WebTools and Razor).

Unifies namespaces the types are defined in to Microsoft.CodeAnalysis.Threading.

TODO:

  • Create Microsoft.CodeAnalysis.Contracts source package that contains the source files linked as "External" in the Microsoft.CodeAnalysis.Threading package project, so that they don't need to be duplicated by the projects using the source package: Add Microsoft.CodeAnalysis.Contracts source package #76997
  • Rename Microsoft.CodeAnalysis.Shared.TestHooks namespace to Microsoft.CodeAnalysis.Threading.TestHooks

image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 27, 2025
@tmat tmat changed the title Move to Threading namespace Move async utils to Microsoft.CodeAnalysis.Threading source package Jan 27, 2025
@tmat tmat marked this pull request as ready for review January 28, 2025 02:58
@tmat tmat requested review from a team as code owners January 28, 2025 02:59
@tmat
Copy link
Member Author

tmat commented Jan 28, 2025

@dotnet/roslyn-compiler A few minor changes to compiler code, ptal

@tmat tmat enabled auto-merge (squash) February 4, 2025 21:23
@tmat tmat merged commit dead7da into dotnet:main Feb 5, 2025
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Feb 5, 2025
@tmat tmat deleted the Threading branch February 5, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants