Hook brace-matching up to the 'responsive completion' editor option #76746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jan 14, 2025
| @@ -47,6 +47,10 @@ internal partial class BraceCompletionSessionProvider( | |||
| public bool TryCreateSession(ITextView textView, SnapshotPoint openingPoint, char openingBrace, char closingBrace, out IBraceCompletionSession session) | |||
| { | |||
| _threadingContext.ThrowIfNotOnUIThread(); | |||
|
|
|||
| var isResponsive = textView.Options.GetOptionValue(DefaultOptions.ResponsiveCompletionOptionId); | |||
| var responsiveThreshold = isResponsive ? textView.Options.GetOptionValue(DefaultOptions.ResponsiveCompletionThresholdOptionId) : -1; | |||
There was a problem hiding this comment.
defaults for this are 'true + 250ms'.
ToddGrun
reviewed
Jan 14, 2025
| // Brace completion is cancellable if the user has the 'responsive completion' option enabled. | ||
| var cancellationTokenSource = new CancellationTokenSource(); | ||
| if (_timeoutThreshold > 0) | ||
| cancellationTokenSource.CancelAfter(_timeoutThreshold); |
There was a problem hiding this comment.
consider something like to encapsulate the cancellationtokensource usage:
var cancellationToken = GetCancellationToken();
...
CancellationToken GetCancellationToken()
{
if (_timeoutThreshold <= 0)
return CancellationToken.None;
var cancellationTokenSource = new CancellationTokenSource();
cancellationTokenSource.CancelAfter(_timeoutThreshold);
return cancellationTokenSource.Token;
}
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, if brace matching is taking too long, we can responsibly cancel it and unblock typing.