Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pointless xml doc comment tags #76696

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners January 9, 2025 19:23
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 9, 2025
@@ -19,7 +19,6 @@ internal interface IBrokeredServiceBridgeManifest
/// Returns services that the container wishes to expose across the bridge.
/// </summary>
/// <param name="cancellationToken"></param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

@@ -325,7 +325,6 @@ public static ContainerElement ToLSPElement(this QuickInfoContainerElement eleme
/// in the Visual Studio client.
/// </summary>
/// <param name="glyph"></param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

@@ -352,7 +352,6 @@ private static IEnumerable<PackagePart> GetPartsInFolder(Package package, string
/// properly update this package.
/// </summary>
/// <param name="textWriter"></param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

@@ -310,7 +309,6 @@ private static void ThrowUnableToFindChildException(string path, IUIAutomationEl
/// support the <see cref="IUIAutomationTogglePattern"/>.
/// </summary>
/// <param name="element"></param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to continue commenting on these, but there's a bunch 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StyleCop Analyzers has analyzers for these cases if we decide they matter.

Comment on lines 183 to 185
/// <summary>
///
/// </summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this whole block be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely yes :) just dealing with the simple case for noww: )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants