Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have inline hints display aliases if appropriate #76530

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Dec 19, 2024

Fixes: #72219

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 19, 2024 22:42
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 19, 2024
@@ -766,7 +766,7 @@ class A
<Document>
class A
{
void M(System.Threading.CancellationToken ct = new CancellationToken()) { }
void M(System.Threading.CancellationToken ct = new System.Threading.CancellationToken()) { }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a desirable change. The code emit before was emitting code that wouldn't compile.

@CyrusNajmabadi
Copy link
Member Author

@akhera99 ptal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inlay Hint type should take into account using alias
3 participants