Delete task extension used only by the interactive window. #76450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Dec 16, 2024
| @@ -41,36 +41,35 @@ internal ResetInteractive(EditorOptionsService editorOptionsService, Func<string | |||
| _createImport = createImport; | |||
| } | |||
|
|
|||
| internal Task ExecuteAsync(IInteractiveWindow interactiveWindow, string title) | |||
| internal async Task ExecuteAsync(IInteractiveWindow interactiveWindow, string title) | |||
There was a problem hiding this comment.
caller of this was going an await anyways, so there was no reason i could figure out for this to be written as task returning, with task continuations, instead of just normal async/await.
CyrusNajmabadi
commented
Dec 16, 2024
| // Now, we're going to do a bunch of async operations. So create a wait | ||
| // indicator so the user knows something is happening, and also so they cancel. | ||
| var uiThreadOperationExecutor = GetUIThreadOperationExecutor(); | ||
| using var context = uiThreadOperationExecutor.BeginExecute(title, EditorFeaturesWpfResources.Building_Project, allowCancellation: true, showProgress: false); |
There was a problem hiding this comment.
a normal using now, so we don't need an explicit dispose.
CyrusNajmabadi
commented
Dec 16, 2024
| projectNamespaces, | ||
| projectDirectory, | ||
| platform, | ||
| context).ConfigureAwait(true); |
There was a problem hiding this comment.
intentionally CA(True) since hte original code did a ContinueWith with FromCurrentSynchronizationContext.
CyrusNajmabadi
commented
Dec 16, 2024
| finally | ||
| { | ||
| // Once we're done resetting focus the REPL window. | ||
| ExecutionCompleted?.Invoke(this, new EventArgs()); |
There was a problem hiding this comment.
in a finally, so we always do this regardless of cancellation (Teh semantics of SafeContinueWith).
|
@tmat ptal |
|
@dotnet/roslyn-ide @jasonmalinowski ptal |
JoeRobich
approved these changes
Dec 17, 2024
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #76448