Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PR Val builds to be unsigned #76358

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Change PR Val builds to be unsigned #76358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82a501f
Change PR Val builds to be test signed
JoeRobich Dec 10, 2024
3cea840
reorder
JoeRobich Dec 10, 2024
480717b
Do not sign .nupkg when performing PR validation
JoeRobich Dec 11, 2024
c03725a
Do not sign artifacts when performing PR validation
JoeRobich Dec 12, 2024
9d24397
Clear SignType for PR validation builds
JoeRobich Dec 13, 2024
dc71f98
Update eng/Signing.props
JoeRobich Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions azure-pipelines-pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ variables:
value: false
- name: Codeql.SkipTaskAutoInjection
value: true
- name: SignType
value: ''

# To retrieve OptProf data we need to authenticate to the VS drop storage.
# If the pipeline is running in DevDiv, the account has access to the VS drop storage.
Expand Down Expand Up @@ -339,5 +341,6 @@ extends:
# Symbol validation is not entirely reliable as of yet, so should be turned off until
# https://github.com/dotnet/arcade/issues/2871 is resolved.
enableSymbolValidation: false
enableSigningValidation: false
enableSourceLinkValidation: false
SDLValidationParameters: false
15 changes: 15 additions & 0 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,19 @@
<FileSignInfo Include="Microsoft.VisualStudio.Threading.dll" CertificateName="MicrosoftSHA2" />
<FileSignInfo Include="StreamJsonRpc.dll" CertificateName="MicrosoftSHA2" />
</ItemGroup>

<!--
We do not intend to ship the artifacts produced for PR validation build so we can skip signing the artifacts.
-->
<Choose>
<When Condition="'$(PreReleaseVersionLabel)' == 'pr-validation' And '$(SignType)' == ''">
<ItemGroup>
<ItemsToSign Remove="@(ItemsToSign)" />
</ItemGroup>

<PropertyGroup>
<AllowEmptySignList>true</AllowEmptySignList>
</PropertyGroup>
</When>
</Choose>
</Project>
Loading