Update FAR and Go to Def to work on indexers #76220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
Dec 3, 2024
| @@ -66,7 +66,8 @@ internal abstract class AbstractGoToDefinitionSymbolService : IGoToDefinitionSym | |||
| { | |||
| var syntaxTree = await document.GetRequiredSyntaxTreeAsync(cancellationToken).ConfigureAwait(false); | |||
| var syntaxFacts = document.GetRequiredLanguageService<ISyntaxFactsService>(); | |||
| var token = await syntaxTree.GetTouchingTokenAsync(position, syntaxFacts.IsBindableToken, cancellationToken, findInsideTrivia: true).ConfigureAwait(false); | |||
| var token = await syntaxTree.GetTouchingTokenAsync( | |||
| semanticModel: null, position, syntaxFacts.IsBindableToken, cancellationToken, findInsideTrivia: true).ConfigureAwait(false); | |||
There was a problem hiding this comment.
so this helper is GetTargetIfControlFlowAsync. which is basically saying "if you're on a keyword like 'continue' go to the dest of that". That's purely syntactic and doesn't need semantics here.
though let me see if i can clean up duplicative work.
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31819