Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip some integration tests #75970

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Unskip some integration tests #75970

merged 1 commit into from
Jan 9, 2025

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Nov 19, 2024 •
edited
Loading

Closes #75458.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 19, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 19, 2024
Open
3 tasks
@jjonescz jjonescz force-pushed the 75458-Rc1SkippedTests branch from 892c80c to d6641c0 Compare January 7, 2025 14:45
@jjonescz jjonescz force-pushed the 75458-Rc1SkippedTests branch from d6641c0 to 65a1e40 Compare January 8, 2025 10:00
@jjonescz jjonescz changed the title Unskip integration tests Unskip some integration tests Jan 8, 2025
@jjonescz jjonescz marked this pull request as ready for review January 8, 2025 12:10
@jjonescz jjonescz requested a review from a team as a code owner January 8, 2025 12:10
CyrusNajmabadi
CyrusNajmabadi approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What made it ok to unskip these?

@jjonescz
Copy link
Member Author

jjonescz commented Jan 8, 2025

What made it ok to unskip these?

Not sure, my guess is a newer VS version on the CI machines.

@CyrusNajmabadi
Copy link
Member

My concern is if these were skipped for being flakey. Will we be adding flakeyness back into ci?

@jjonescz
Copy link
Member Author

jjonescz commented Jan 8, 2025 •
edited
Loading

I actually don't know if they were flaky, I assumed they just stopped working completely when we were updating sdk to .net 9 rc1 - see #75458 and #75211 - @jaredpar / @akhera99 skipped them, so they might know

@CyrusNajmabadi
Copy link
Member

Ah ok. I'm good with them being unskipped them

@jjonescz jjonescz merged commit a07d8af into dotnet:main Jan 9, 2025
25 checks passed
@jjonescz jjonescz deleted the 75458-Rc1SkippedTests branch January 9, 2025 09:44
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 9, 2025
This was referenced Jan 14, 2025
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

The .NET 9 RC1 SDK is blocking a few integration test
2 participants
@jjonescz @CyrusNajmabadi