Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't map spans for aspx files #75909

Merged
merged 1 commit into from
Nov 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,12 @@ await getTextSpanForMappingAsync(document).ConfigureAwait(false),
// If the mapped file maps to the same document that was passed in, then re-use the documentId to preserve context.
// Otherwise, just pick one of the ids to use for navigation.
var documentIdToNavigate = documentIdsForFilePath.Contains(documentId) ? documentId : documentIdsForFilePath.First();
return GetNavigationCallback(
documentIdToNavigate,
workspace,
sourceText => getVsTextSpanForMapping(sourceText, mappedSpan.Span));

// For Venus documents, further mapping is done in the callback, so we don't want to do it here via getVsTextSpanForMapping
var getSpanForCallback = IsSecondaryBuffer(documentIdToNavigate)
? getVsTextSpan
: sourceText => getVsTextSpanForMapping(sourceText, mappedSpan.Span);
return GetNavigationCallback(documentIdToNavigate, workspace, getSpanForCallback);
}

return await GetNavigableLocationForMappedFileAsync(
Expand Down
Loading