Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify shape of APIs used for Overload Resolution Priority feature #75891

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Simplify shape of APIs used for Overload Resolution Priority feature #75891

merged 2 commits into from
Nov 15, 2024

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested a review from a team as a code owner November 13, 2024 17:03
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 13, 2024
@AlekseyTs AlekseyTs requested review from 333fred and cston November 13, 2024 19:06
@AlekseyTs
Copy link
Contributor Author

@333fred, @cston, @dotnet/roslyn-compiler Please review

@AlekseyTs
Copy link
Contributor Author

@cston, @dotnet/roslyn-compiler For the second review

1 similar comment
@AlekseyTs
Copy link
Contributor Author

@cston, @dotnet/roslyn-compiler For the second review

cston
cston reviewed Nov 14, 2024
View reviewed changes
src/Compilers/CSharp/Portable/Symbols/MethodSymbol.cs

internal abstract int? TryGetOverloadResolutionPriority();
internal abstract int TryGetOverloadResolutionPriority();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TryGetOverloadResolutionPriority

Should this method be called GetOverloadResolutionPriority now rather than TryGet... since we're no longer distinguishing between unset and set to default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the name as it is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should this be a property? internal abstract int OverloadResolutionPriority { get; }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think there is a requirement for that.

@AlekseyTs AlekseyTs merged commit ab8015d into dotnet:main Nov 15, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 15, 2024
This was referenced Nov 17, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - Overload Resolution Priority untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekseyTs @333fred @cston @jjonescz