Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET 9 runtime for single machine CI job #75889

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Nov 13, 2024

Fixes this error in the single machine CI leg (which runs only in main branch):

Testhost process for source(s) 'D:\a\_work\1\s\artifacts\bin\Roslyn.Compilers.VisualBasic.IOperation.UnitTests\Debug\net9.0\Roslyn.Compilers.VisualBasic.IOperation.UnitTests.dll' exited with error: You must install or update .NET to run this application.
App: D:\a\_work\1\s\artifacts\bin\Roslyn.Compilers.VisualBasic.IOperation.UnitTests\Debug\net9.0\testhost.exe
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '9.0.0-rc.2.24473.5' (x64)
.NET location: D:\a\_work\1\s\.dotnet
The following frameworks were found:
  9.0.0-preview.3.24172.9 at [D:\a\_work\1\s\.dotnet\shared\Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-rc.2.24473.5&arch=x64&rid=win-x64&os=win10
. Please check the diagnostic logs for more information.
Test Run Aborted.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 13, 2024
@jjonescz jjonescz marked this pull request as ready for review November 13, 2024 17:26
@jjonescz jjonescz requested a review from a team as a code owner November 13, 2024 17:26
@@ -33,7 +33,7 @@ jobs:
displayName: 'Install .NET 9 Runtime'
inputs:
packageType: runtime
version: 9.0.0-preview.3.24172.9
version: 9.0.0-rc.2.24473.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man I wish it were more straightforward to flow the sdk version from global.json here. This is obviously prone to fall out of date, but, I'm not sure we can justify the investigation effort at this point either.

Copy link
Contributor

@RikkiGibson RikkiGibson Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a useGlobalJson task parameter but surely no use if global.json is not on disk on the test machine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I might look into this later (perhaps when arcade bumps SDK and I will need to do this again). But for now, the tests are actually failing on some assert, so I'm going to prioritize investigating that.

@jjonescz jjonescz marked this pull request as draft November 14, 2024 11:29
@jjonescz
Copy link
Member Author

@sharwell @tmat it looks like the test Microsoft.CodeAnalysis.UnitTests.Interactive.InteractiveHostDesktopTests.Bitness fails when calling InteractiveHost.Reset. The failure is from here:

Assert.False(true, (exception?.Message ?? "Host process terminated unexpectedly.") + $" Exit code: {exitCode?.ToString() ?? "<unknown>"}");

And it only fails on the Single_Machine leg. There aren't any details about the error. Any ideas what to do about it?

The last build where it worked is https://dev.azure.com/dnceng-public/public/_build/results?buildId=866953. It was running on a machine with .NET runtime 9.0.0-preview.3.24172.9 and VS 17.11.0 Preview 2.1. Then the CI machine updated to VS 17.12.0 Preview 4 it seems and so I needed to update the .NET runtime to 9.0.100-rc.2.24474.11 (see the error in this PR's description).

@jjonescz jjonescz marked this pull request as ready for review November 15, 2024 13:17
@jjonescz jjonescz merged commit bf1ec77 into dotnet:main Nov 15, 2024
35 checks passed
@jjonescz jjonescz deleted the single-machine branch November 15, 2024 13:17
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 15, 2024
jjonescz added a commit that referenced this pull request Nov 21, 2024
* Update .NET 9 runtime for single machine CI job

* Use regular pool
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants