Add more cases supported by 'use collection expression' #75879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Nov 13, 2024
| @@ -20,11 +20,6 @@ internal sealed partial class CSharpUseCollectionExpressionForCreateDiagnosticAn | |||
| IDEDiagnosticIds.UseCollectionExpressionForCreateDiagnosticId, | |||
| EnforceOnBuildValues.UseCollectionExpressionForCreate) | |||
| { | |||
| public const string UnwrapArgument = nameof(UnwrapArgument); | |||
|
|
|||
| private static readonly ImmutableDictionary<string, string?> s_unwrapArgumentProperties = | |||
There was a problem hiding this comment.
moved to common location
CyrusNajmabadi
commented
Nov 13, 2024
| var properties = unwrapArgument ? s_unwrapArgumentProperties : ImmutableDictionary<string, string?>.Empty; | ||
| if (changesSemantics) | ||
| properties = properties.Add(UseCollectionInitializerHelpers.ChangesSemanticsName, ""); | ||
| var properties = GetDiagnosticProperties(unwrapArgument, useSpread, changesSemantics); |
There was a problem hiding this comment.
moved to common location
CyrusNajmabadi
commented
Nov 13, 2024
| nameof(ParallelEnumerable), | ||
| nameof(ParallelQuery), | ||
| // Special internal runtime interface that is optimized for fast path conversions of collections. | ||
| "IIListProvider"]; |
There was a problem hiding this comment.
moved to common location
CyrusNajmabadi
commented
Nov 13, 2024
| Implements(type, compilation.IReadOnlyListOfTType()); | ||
| } | ||
|
|
||
| bool IsIterable(ExpressionSyntax expression) |
There was a problem hiding this comment.
moved to common location
CyrusNajmabadi
commented
Nov 13, 2024
| internal sealed partial class CSharpUseCollectionExpressionForNewDiagnosticAnalyzer() | ||
| : AbstractCSharpUseCollectionExpressionDiagnosticAnalyzer( | ||
| IDEDiagnosticIds.UseCollectionExpressionForNewDiagnosticId, | ||
| EnforceOnBuildValues.UseCollectionExpressionForNew) |
There was a problem hiding this comment.
supports converting new List<...>(x) to [.. x]
CyrusNajmabadi
commented
Nov 13, 2024
| { | ||
| var argExpression = arguments[0].Expression; | ||
| if (argExpression |
CyrusNajmabadi
commented
Nov 13, 2024
3 tasks
CyrusNajmabadi
changed the title
akhera99
approved these changes
Nov 14, 2024
| { | ||
| void M() | ||
| { | ||
| const bool shouldParallelize = false; |
| } | ||
|
|
||
| [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/71145")] | ||
| public async Task TestNotInParallelEnumerable2() |
There was a problem hiding this comment.
The "Not" in the name makes me think it should not convert to a collection expression
There was a problem hiding this comment.
Correct. We didn't update hte parallel one, only the non parallel one :)
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75870