Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to torn analyzers #75533

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Remove references to torn analyzers #75533

merged 5 commits into from
Oct 17, 2024

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 16, 2024 18:49
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 16, 2024
sharwell
sharwell requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure EnforceCodeStyleInBuild is set in the correct cases. I need to review the current use of RoslynCheckCodeStyle and RoslynEnforceCodeStyle to see what those cases are.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 16, 2024 22:23
@CyrusNajmabadi CyrusNajmabadi merged commit e5a4963 into dotnet:main Oct 17, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 17, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the removeTornAnalyzers branch October 17, 2024 20:19
This was referenced Oct 22, 2024
Closed
Closed
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
@dotnet-bot dotnet-bot mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @JoeRobich @sharwell @akhera99