Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'await completion' adding async to the wrong member #75517

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #67952

Has been bothering me a while :)

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 15, 2024 20:42
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 15, 2024
@CyrusNajmabadi CyrusNajmabadi requested a review from genlu October 15, 2024 20:52
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit f548d02 into dotnet:main Oct 15, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 15, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the awaitCompletion branch October 16, 2024 17:01
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

await completion adds async to unrelated local function instead of the containing method declaration
3 participants