-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also compare other properties when remove block spans #75515
Merged
Cosifne
merged 3 commits into
dotnet:main
from
Cosifne:dev/shech/FixCollapseToDefinition
Oct 16, 2024
Merged
Also compare other properties when remove block spans #75515
Cosifne
merged 3 commits into
dotnet:main
from
Cosifne:dev/shech/FixCollapseToDefinition
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Oct 15, 2024
CyrusNajmabadi
approved these changes
Oct 16, 2024
Cosifne
added a commit
to Cosifne/roslyn
that referenced
this pull request
Oct 16, 2024
…efinition Also compare other properties when remove block spans
Merged
Cosifne
added a commit
that referenced
this pull request
Oct 16, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2112145
Right now you can't call
collapse to definition
in this case:It is regressed back in #71064
In that PR we want to support a scenario:
only M2 will be collapsed.
The implementation is to compare the start line of the block span (later it changes to compare both start & end line in #74413)
However, the problem is in the lamda case:
Method
YX
and lambdagenerate two block spans with same line start and line end. But
AutoCollapse
proprety is different,roslyn/src/Features/CSharp/Portable/Structure/Providers/ArrowExpressionClauseStructureProvider.cs
Line 30 in 0068ee9
roslyn/src/Features/CSharp/Portable/Structure/Providers/SimpleLambdaExpressionStructureProvider.cs
Line 45 in 0068ee9
Fix is to also compare other properties in Block span when remove them from the context.
After the PR: