Field-backed properties: [field:] should not be considered a backing field reference #75461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
approved these changes
Oct 10, 2024
RikkiGibson
reviewed
Oct 10, 2024
| var attributes = attributeList.Attributes; | ||
| for (int i = 0; i < attributes.Count; i++) | ||
| { | ||
| if (containsFieldExpressionInGreenNode(attributes[i])) |
There was a problem hiding this comment.
so is the idea that this way of visiting the syntax is skipping the attribute target?
There was a problem hiding this comment.
Yes, we're skipping the attribute target. I've since changed containsFieldExpressionInGreenNode() to look for FieldExpression rather than FieldToken, so this change is no longer strictly necessary, but it seemed reasonable to me to keep both changes.
RikkiGibson
approved these changes
Oct 10, 2024
333fred
approved these changes
Oct 10, 2024
cston
added a commit
to cston/roslyn
that referenced
this pull request
Oct 15, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attribute with a
field:target used on a property accessor was incorrectly considered a reference to the backing field, resulting in a synthesized field for the property.Fixes #75459.