VB: Do not use overload resolution while lowering interpolated strings #75449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@dotnet/roslyn-compiler Please review |
1 similar comment
|
@dotnet/roslyn-compiler Please review |
333fred
approved these changes
Oct 11, 2024
| @@ -78,117 +79,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic | |||
| ' | |||
| ' (2) For the built-in types, we can use .ToString(string format) for some format strings. | |||
| ' Detect those cases that can be handled that way and take advantage of them. | |||
There was a problem hiding this comment.
Should we remove this comment now, since it's done in initial binding? Or mention that this transformation was done during initial binding and the result is in ConstructionOpt? #Resolved
There was a problem hiding this comment.
Should we remove this comment now, since it's done in initial binding? Or mention that this transformation was done during initial binding and the result is in
ConstructionOpt?
I do not think there is a need to do either.
|
@dotnet/roslyn-compiler For the second review |
|
Looking |
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #74275.