Move to the real System.ValueTuple ref #74936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler PTAL |
jaredpar
commented
Aug 28, 2024
|
|
||
| /* | ||
| * ⚠ Dev note ⚠: TestBase properties end here. | ||
| */ |
There was a problem hiding this comment.
This comment was moved up because the properties below no longer depend on TestBase
333fred
approved these changes
Aug 28, 2024
jjonescz
approved these changes
Aug 29, 2024
333fred
reviewed
Aug 30, 2024
Open
3 tasks
cston
reviewed
Aug 30, 2024
cston
reviewed
Aug 30, 2024
cston
reviewed
Aug 30, 2024
| SymbolDisplayPartKind.Punctuation, | ||
| SymbolDisplayPartKind.Keyword, | ||
| SymbolDisplayPartKind.Space, | ||
| SymbolDisplayPartKind.StructName, | ||
| SymbolDisplayPartKind.Punctuation}, | ||
| references:={MetadataReference.CreateFromImage(TestResources.NetFX.ValueTuple.tuplelib)}) | ||
| references:={Net461.ExtraReferences.SystemValueTuple}) |
There was a problem hiding this comment.
I thought about that but symbol display is a user visible artifact. Decided that it was better to have our tests track down Tuple displays in the 99.999% case vs. the .001% case that I'm not sure you can reaally achieve.
cston
approved these changes
Aug 30, 2024
cston
approved these changes
Aug 30, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.