Cherrypick (#73873) into 17.11 #74503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3873) * work in progress on getting context and almost passing it to smart rename * pass context to SmartRenameSession * attempt to set PromptOverride through Lightup * reflection refinement * Fix CreatePropertySetter in LightupHelpers * Find definitions and references and add them to the context * also capture snippet of surrounding method * simplify * fix GetRequiredLanguageService * undo code cleanup artifacts * use ImmutableArray throughout Roslyn's interfaces * fixup * refactor to get context only if smart rename is active * revert the now unnecessary change * restore CreateFunctionAccessor with 2 parameters * Dont duplicate work of getting rename locations * use interface in the method declarations * fix warning * remove IInlineRenameSession from the API * cleanup * refactor getting doccomments * fixup * PR feedback * Add IEditorInlineRenameService.IsRenameContextSupported * revert unnecessary change * remove unnecessary changes * doc comments * expose TriggerDocument instead of creating a property that returns a field * add feature flag to control whether we're getting context * improve event handler name * fix Correctness_Analyzers warnings * update Feature Flag look * fix Freeing Twice assert * add 'requires restart' to the FF name * cleanup usings * extract constants * remove unused code * NumberOfContextLines const * GetRenameContextCoreAsync doc comments * pr feedback on CSharpEditorInlineRenameService * override fixes * enforce hard limits on amount of symbols we traverse * Get context off UI thread, respond to property changed on UI thread * undo unwanted file * Remove CSharpRenameContextHelper; improve the provided context * modifiers and doc comments * remove never taken branch * Remove IsRenameContextSupported * PR feedback to move TryGetSurroundingNodeSpanAsync to parent class * use CompletesAsyncOperation pattern for SessionPropertyChanged * Create IAsynchronousOperationListener in the constructor * improve algorithm that provides context snippet --------- Co-authored-by: Shen Chen <shech@microsoft.com>
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
arkalyanms
approved these changes
Jul 23, 2024
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick #73873