Unify code paths that update ordinary/additional/analyzerconfig documents #74441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
tmat
commented
Jul 18, 2024
| } | ||
| } | ||
|
|
||
| internal sealed class TouchAnalyzerConfigDocumentsAction( |
There was a problem hiding this comment.
Separate this action from ProjectCompilationOptionsAction.
tmat
commented
Jul 18, 2024
| } | ||
|
|
||
| return null; | ||
| } | ||
| } | ||
|
|
||
| internal sealed class TouchAdditionalDocumentAction( | ||
| internal sealed class TouchAdditionalDocumentsAction( |
There was a problem hiding this comment.
Allow multiple documents to be changed at the same time, like TouchDocumentsAction.
tmat
commented
Jul 18, 2024
| @@ -856,34 +869,36 @@ public ProjectState UpdateDocuments(ImmutableArray<DocumentState> newDocuments, | |||
| } | |||
|
|
|||
| public ProjectState UpdateAdditionalDocument(AdditionalDocumentState newDocument, bool contentChanged) | |||
| => UpdateAdditionalDocuments([AdditionalDocumentStates.GetRequiredState(newDocument.Id)], [newDocument], contentChanged); | |||
|
|
|||
| public ProjectState UpdateAdditionalDocuments(ImmutableArray<AdditionalDocumentState> oldDocuments, ImmutableArray<AdditionalDocumentState> newDocuments, bool contentChanged) | |||
There was a problem hiding this comment.
Follow the same pattern as UpdateDocuments
tmat
force-pushed
the
DocumentStateUpdating
branch
from
4a654a8
to
7b2064b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
tmat
force-pushed
the
DocumentStateUpdating
branch
from
c432a2c
to
38012d8
Compare
tmat
changed the title
tmat
force-pushed
the
DocumentStateUpdating
branch
from
38012d8
to
8fbb4cd
Compare
|
@ToddGrun ptal |
ToddGrun
reviewed
Jul 23, 2024
|
|
||
| // Must not be empty as we would have otherwise bailed out in the check above. | ||
| Contract.ThrowIfTrue(newDocuments.IsEmpty); | ||
| Contract.ThrowIfTrue(oldDocuments.IsEmpty); |
There was a problem hiding this comment.
Not sure I follow. The contract has been there before.
There was a problem hiding this comment.
But it would have returned before hitting the contract failure previously, right?
ToddGrun
reviewed
Jul 23, 2024
ToddGrun
reviewed
Jul 23, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Jul 23, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Jul 23, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.cs
Show resolved
Hide resolved
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of ProjectState and SolutionCompilationState.