Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assembly loading light-up from scripting #74409

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 16, 2024

Replace reflection light-ups with #ifdefs - the light up is from times when we did not have multi-targeting.

Cleans up the code and enables nullable checks.

Contributes to dotnet/source-build#4482

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 16, 2024
@tmat tmat marked this pull request as ready for review July 16, 2024 21:07
@tmat tmat requested a review from a team as a code owner July 16, 2024 21:07
@tmat
Copy link
Member Author

tmat commented Jul 16, 2024

@dotnet/roslyn-ide @jaredpar ptal

@tmat tmat merged commit 5998125 into dotnet:main Jul 25, 2024
25 checks passed
@tmat tmat deleted the ScriptingAL branch July 25, 2024 00:39
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 25, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants