Switch to STJ for client side LSP serialization #74364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| public override Task HandleNotificationAsync(string methodName, JsonElement methodParam, Func<JsonElement, Task> sendNotification) | ||
| { | ||
| // Razor only ever looks at the method name, so it is safe to pass null for all the Newtonsoft JToken params. | ||
| return _razorCSharpInterceptionMiddleLayer.HandleNotificationAsync(methodName, null!, null!); |
CyrusNajmabadi
approved these changes
Jul 12, 2024
3 tasks
ToddGrun
reviewed
Jul 15, 2024
| @@ -3,19 +3,20 @@ | |||
| // See the LICENSE file in the project root for more information. | |||
|
|
|||
| using System; | |||
| using System.Text.Json; | |||
| using System.Threading.Tasks; | |||
| using Microsoft.VisualStudio.LanguageServer.Client; | |||
| using Newtonsoft.Json.Linq; | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.Editor.Implementation.LanguageClient; | |||
|
|
|||
| #pragma warning disable CS0618 // Type or member is obsolete - blocked on Razor switching to new APIs for STJ - https://github.com/dotnet/roslyn/issues/73317 | |||
ToddGrun
reviewed
Jul 15, 2024
| @@ -267,6 +268,13 @@ public Task OnServerInitializedAsync() | |||
| /// </summary> | |||
| public Task AttachForCustomMessageAsync(JsonRpc rpc) => Task.CompletedTask; | |||
|
|
|||
| private static PropertyCollection CreateStjPropertyCollection() | |||
There was a problem hiding this comment.
the vslanguageserverclient code indicates this is a temporary measure for 17.10. Is there going to be a better way to do this soon?
There was a problem hiding this comment.
Yes, the client will be opting into STJ by default in 17.12 Preview 1, at which point we can remove this. However we have additional changes, so we need to go in first with an explicit opt-in.
ToddGrun
reviewed
Jul 15, 2024
ToddGrun
reviewed
Jul 15, 2024
src/Tools/ExternalAccess/Razor/RazorCSharpInterceptionMiddleLayer.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Jul 16, 2024
ToddGrun
reviewed
Jul 16, 2024
src/EditorFeatures/Core/LanguageServer/AbstractInProcLanguageClient.cs
Outdated
Show resolved
Hide resolved
arkalyanms
approved these changes
Jul 17, 2024
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #73317
PR val - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/565009