Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug assert with operation blocks in invalid code #74354

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #74315

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners July 11, 2024 16:34
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 11, 2024
@CyrusNajmabadi
Copy link
Member Author

@333fred ptal

@CyrusNajmabadi
Copy link
Member Author

@dotnet/roslyn-compiler One line change. Tnx.

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/74315")]
public async Task TestOperationConstructorBlockCallbackOnInvalidBaseCall()
{
// lang=C#-Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lang=C# turns on syntax highlighting in the string, right? but what does lang=C#-Test do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marks it as a C# test file, with supported C# test file syntax. Note; we don't have lang=c# support (yet). but it's something we could consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert failure in AnalyzerDriver
4 participants