Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to verify ref safety bug fix #74341

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

jaredpar
Copy link
Member

These tests verify that issue #63852 is fixed. It was very likely fixed
as part of #73081

closes #63852

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 10, 2024
@jaredpar
Copy link
Member Author

Waiting for #73842 to merge before publishing

These tests verify that issue dotnet#63852 is fixed. It was very likely fixed
as part of dotnet#73081

closes dotnet#63852
@jaredpar jaredpar marked this pull request as ready for review July 15, 2024 13:19
@jaredpar jaredpar requested a review from a team as a code owner July 15, 2024 13:19
@jaredpar
Copy link
Member Author

@cston, @jjonescz, @RikkiGibson PTAL test change to verify bug fix

@jaredpar jaredpar force-pushed the ref-more-fix branch 2 times, most recently from 33411cd to 77b5387 Compare July 15, 2024 13:41
[InlineData(LanguageVersion.CSharp10)]
[InlineData(LanguageVersion.CSharp11)]
[WorkItem("https://github.com/dotnet/roslyn/issues/63852")]
public void UserDefinedBinaryOperator_RefStruct_Compound_RegressionTest1(LanguageVersion languageVersion)
Copy link
Member

@cston cston Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserDefinedBinaryOperator_RefStruct_Compound_RegressionTest1

This looks like the first case in the subsequent test. If so, consider deleting this test.

Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
@jaredpar jaredpar merged commit ba25420 into dotnet:main Jul 22, 2024
24 checks passed
@jaredpar jaredpar deleted the ref-more-fix branch July 22, 2024 13:01
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 22, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ref escape analysis errors are not reported for compound assignment
4 participants