Do not use memory mapped files on non-windows #74339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Jul 10, 2024
| // Serialization to temporary storage is only involved when we have a remote process. Which is only in VS. So the type of the | ||
| // storage service here is well known. However the serializer is created in other cases (e.g. to compute project state checksums). | ||
| // So lazily instantiate the storage service to avoid attempting to get the TemporaryStorageService when not available. | ||
| _storageService = new Lazy<TemporaryStorageService>(() => (TemporaryStorageService)workspaceServices.GetRequiredService<ITemporaryStorageServiceInternal>()); |
There was a problem hiding this comment.
A bit weird. the serializer service is almost only used for oop serialization - except its also used for create project parse option checksums on all platforms.
The TemporaryStorageService is not used in that case, so instantiating it lazily to avoid throwing when it attempts to convert to TemporaryStorageService
dibarbet
commented
Jul 10, 2024
|
|
||
| namespace Microsoft.CodeAnalysis; | ||
|
|
||
| internal sealed class TrivialTemporaryStorageService : ITemporaryStorageServiceInternal |
There was a problem hiding this comment.
CyrusNajmabadi
approved these changes
Jul 10, 2024
Open
3 tasks
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different version of #73628
Resolves dotnet/vscode-csharp#7119
Memory mapped files on linux are saved to /dev/shm/ which has a tiny size by default in docker containers. This causes the server to crash. Fix is to only use memory mapped files when OOP is required (Windows).