Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fallbacks (3) #74323

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Remove fallbacks (3) #74323

merged 3 commits into from
Jul 11, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 9, 2024

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 9, 2024
@tmat tmat force-pushed the RemoveFallbacks3 branch 2 times, most recently from 9aa4191 to 52bafb6 Compare July 10, 2024 19:20
@tmat tmat marked this pull request as ready for review July 10, 2024 21:10
@tmat tmat requested a review from a team as a code owner July 10, 2024 21:10
CyrusNajmabadi
CyrusNajmabadi approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. trusting that the default values stayed the same.

@tmat tmat enabled auto-merge (squash) July 10, 2024 21:43
@tmat tmat mentioned this pull request Jul 10, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Jul 11, 2024
Open
3 tasks
@tmat tmat merged commit c649fbb into dotnet:main Jul 11, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 11, 2024
@tmat tmat deleted the RemoveFallbacks3 branch July 11, 2024 04:33
This was referenced Jul 16, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @CyrusNajmabadi @RikkiGibson