Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable BuildWithNetFrameworkHostedCompiler #74299

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Disable BuildWithNetFrameworkHostedCompiler #74299

merged 1 commit into from
Jul 9, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 9, 2024

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 9, 2024
@jjonescz jjonescz marked this pull request as ready for review July 9, 2024 08:26
@jjonescz jjonescz requested a review from a team as a code owner July 9, 2024 08:26
@jjonescz
Copy link
Member Author

jjonescz commented Jul 9, 2024 •
edited
Loading

Note: DartLab build succeeds which demonstrates this works - previously DartLab builds were failing with error NU1010: The PackageReference items Microsoft.Net.Compilers.Toolset.Framework do not have corresponding PackageVersion.. The DartLab CI check is red because some tests are failing, might be flaky integration tests or something the IDE team should look at (but that's unrelated to this PR).

@AmadeusW
Copy link
Contributor

AmadeusW commented Jul 9, 2024

Just wanted to add that I've been running into the same NU1010 issue in all of my local development environments (not DartLab). Applying this fix allows me to restore and build roslyn.

@jjonescz jjonescz merged commit 5c2d76c into dotnet:main Jul 9, 2024
28 of 29 checks passed
@jjonescz jjonescz deleted the toolset-cpm branch July 9, 2024 17:18
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 9, 2024
@jjonescz jjonescz mentioned this pull request Jul 9, 2024
Merged
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 9, 2024
@333fred
Merge remote-tracking branch 'upstream/main' into feature/overload-re…
730aea7 
…solution-priority

* upstream/main: (184 commits)
  Disable BuildWithNetFrameworkHostedCompiler (dotnet#74299)
  Avoid using constants for large string literals (dotnet#74305)
  Adjust lowering of a string interpolation in an expression lambda to not use expanded non-array `params` collection in Format/Create calls. (dotnet#74274)
  Consolidate test Span sources (dotnet#74281)
  Allow Document.FilePath to be set to null (dotnet#74290)
  Update Directory.Build.rsp
  Remove fallback options from IdeAnalyzerOptions (dotnet#74235)
  Fix msbuild issue
  Improve parser recovery around nullable types in patterns (dotnet#72805)
  Syntax formatting options (dotnet#74223)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2490585 (dotnet#74287)
  fix (dotnet#74276)
  Remove more
  fix (dotnet#74237)
  Fix scenario where lightbulbs weren't being displayed
  Reduce closures allocated during invocation of CapturedSymbolReplacement.Replacement (dotnet#74258)
  Reduce allocations in SymbolDeclaredCompilationEvent (dotnet#74250)
  remove type that now serves no purpose
  Remove uncalled method
  Remove more unused code
  ...
This was referenced Jul 13, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunchndr arunchndr arunchndr approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @AmadeusW @arunchndr @RikkiGibson