Avoid reporting redundant and possibly misleading WRN_InlineArrayNotSupportedByLanguage #74283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upportedByLanguage Fixes dotnet#73556.
dotnet-issue-labeler
bot
added
the
untriaged
jjonescz
approved these changes
Jul 9, 2024
|
@cston, @dotnet/roslyn-compiler For the second review |
1 similar comment
|
@cston, @dotnet/roslyn-compiler For the second review |
cston
reviewed
Jul 12, 2024
| // (12,7): warning CS9184: 'Inline arrays' language feature is not supported for an inline array type that is not valid as a type argument, or has element type that is not valid as a type argument. | ||
| // S _f; | ||
| Diagnostic(ErrorCode.WRN_InlineArrayNotSupportedByLanguage, "_f").WithLocation(12, 7) | ||
| // (3,12): warning CS9184: 'Inline arrays' language feature is not supported for an inline array type that is not valid as a type argument, or has element type that is not valid as a type argument. |
There was a problem hiding this comment.
warning CS9184: 'Inline arrays' language feature is not supported for an inline array type that is not valid as a type argument, or has element type that is not valid as a type argument.
Is this warning correct? Couldn't S1<T> be used as a type argument a type C<T> where T : allows ref struct? #Resolved
There was a problem hiding this comment.
Is this warning correct?
In a general case a ref struct cannot be used as a type argument. That is the case the warning refers to. If that will be confusing, we will be able to adjust the wording in the future.
cston
approved these changes
Jul 12, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73556.