Fix NFWs due to BG SG system in non C#/VB languages #73922
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| var versionMapBuilder = _sourceGeneratorExecutionVersionMap.Map.ToBuilder(); | ||
| foreach (var projectInfo in projectInfos) | ||
| { | ||
| if (RemoteSupportedLanguages.IsSupported(projectInfo.Language)) |
There was a problem hiding this comment.
note: my original approach was to have the crashing code filter out these project types there as well. But i found that i had to update a whole bunch of locations (you can see that in commit ca92b8f). I didn't like how that was bleeding out. So i just made the change here.
The change we made in #73688 ensures that no matter what the full map is in VS, we always sync just the C#/VB portion over properly when talking to OOP.
|
@ToddGrun @jasonmalinowski ptal. |
this is one of those common cases where we just fail to test out the mixed or non-c#/vb cases. And, thanks to the ABWQ swallowing exceptions (but reporting NFWs) we don't even realize we have an issue. Fix was fairly simple. Note: if you're not mixed, you wouldn't even notice a problem. If you were mixed, you might see SGs not update themselves. |
Pull request was closed
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2085357