Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart Rename: Provide additional context for renamed symbol #73873

Merged
merged 55 commits into from
Jul 17, 2024
Merged

Smart Rename: Provide additional context for renamed symbol #73873

merged 55 commits into from
Jul 17, 2024

Commits on Jun 6, 2024

  1. work in progress on getting context and almost passing it to smart re… 

    …name
    @AmadeusW
    AmadeusW committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3004167 View commit details
    Browse the repository at this point in the history

  2. pass context to SmartRenameSession

    @AmadeusW
    AmadeusW committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    797896b View commit details
    Browse the repository at this point in the history

  3. attempt to set PromptOverride through Lightup

    @AmadeusW
    AmadeusW committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f306f05 View commit details
    Browse the repository at this point in the history

  4. reflection refinement

    @AmadeusW
    AmadeusW committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    dc2c255 View commit details
    Browse the repository at this point in the history

  5. Fix CreatePropertySetter in LightupHelpers

    @Cosifne
    Cosifne committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3cba7f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Find definitions and references and add them to the context

    @AmadeusW
    AmadeusW committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e03d4b8 View commit details
    Browse the repository at this point in the history

  2. also capture snippet of surrounding method

    @AmadeusW
    AmadeusW committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3516915 View commit details
    Browse the repository at this point in the history

  3. simplify

    @AmadeusW
    AmadeusW committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    00a88ec View commit details
    Browse the repository at this point in the history

  4. fix GetRequiredLanguageService

    @AmadeusW
    AmadeusW committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    04f32e4 View commit details
    Browse the repository at this point in the history

  5. undo code cleanup artifacts

    @AmadeusW
    AmadeusW committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8b3f739 View commit details
    Browse the repository at this point in the history

  6. use ImmutableArray throughout Roslyn's interfaces

    @AmadeusW
    AmadeusW committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    14f4c21 View commit details
    Browse the repository at this point in the history

  7. fixup

    @AmadeusW
    AmadeusW committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9a664db View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. refactor to get context only if smart rename is active

    @AmadeusW
    AmadeusW committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2eb5b30 View commit details
    Browse the repository at this point in the history

  2. revert the now unnecessary change

    @AmadeusW
    AmadeusW committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6b3e0a4 View commit details
    Browse the repository at this point in the history

  3. restore CreateFunctionAccessor with 2 parameters

    @AmadeusW
    AmadeusW committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3217dbe View commit details
    Browse the repository at this point in the history

  4. Dont duplicate work of getting rename locations

    @AmadeusW
    AmadeusW committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e6c0de8 View commit details
    Browse the repository at this point in the history

  5. use interface in the method declarations

    @AmadeusW
    AmadeusW committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7b3c5d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. fix warning

    @AmadeusW
    AmadeusW committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0aced56 View commit details
    Browse the repository at this point in the history

  2. remove IInlineRenameSession from the API

    @AmadeusW
    AmadeusW committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5f483e9 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @AmadeusW
    AmadeusW committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7d6f4ea View commit details
    Browse the repository at this point in the history

  4. refactor getting doccomments

    @AmadeusW
    AmadeusW committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fc7c0c7 View commit details
    Browse the repository at this point in the history

  5. fixup

    @AmadeusW
    AmadeusW committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8e7719a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. PR feedback

    @AmadeusW
    AmadeusW committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5abd3f1 View commit details
    Browse the repository at this point in the history

  2. Add IEditorInlineRenameService.IsRenameContextSupported

    @AmadeusW
    AmadeusW committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    13e1afb View commit details
    Browse the repository at this point in the history

  3. revert unnecessary change

    @AmadeusW
    AmadeusW committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c13c161 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary changes

    @AmadeusW
    AmadeusW committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a342e0a View commit details
    Browse the repository at this point in the history

  5. doc comments

    @AmadeusW
    AmadeusW committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    1ff97d8 View commit details
    Browse the repository at this point in the history

  6. expose TriggerDocument instead of creating a property that returns a … 

    …field
    @AmadeusW
    AmadeusW committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d0ef8d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. add feature flag to control whether we're getting context

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    810ef6e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/amwieczo/getContextForRenamedSymbol' of https://git… 

    …hub.com/amadeusw/roslyn into dev/amwieczo/getContextForRenamedSymbol
    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2fe72e4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into dev/amwieczo/getContextForRenamedSymbol

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3eed4a2 View commit details
    Browse the repository at this point in the history

  4. improve event handler name

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e6e6fec View commit details
    Browse the repository at this point in the history

  5. fix Correctness_Analyzers warnings

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    31770e1 View commit details
    Browse the repository at this point in the history

  6. update Feature Flag look

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    02a5426 View commit details
    Browse the repository at this point in the history

  7. fix Freeing Twice assert

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1bc796a View commit details
    Browse the repository at this point in the history

  8. add 'requires restart' to the FF name

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    064eb2e View commit details
    Browse the repository at this point in the history

  9. cleanup usings

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0c0c2ea View commit details
    Browse the repository at this point in the history

  10. extract constants

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    121c396 View commit details
    Browse the repository at this point in the history

  11. remove unused code

    @AmadeusW
    AmadeusW committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f022adf View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. NumberOfContextLines const

    @AmadeusW
    AmadeusW committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    bbe2e44 View commit details
    Browse the repository at this point in the history

  2. GetRenameContextCoreAsync doc comments

    @AmadeusW
    AmadeusW committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c30caf3 View commit details
    Browse the repository at this point in the history

  3. pr feedback on CSharpEditorInlineRenameService

    @AmadeusW
    AmadeusW committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    bf35972 View commit details
    Browse the repository at this point in the history

  4. override fixes

    @AmadeusW
    AmadeusW committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c8788ae View commit details
    Browse the repository at this point in the history

  5. enforce hard limits on amount of symbols we traverse

    @AmadeusW
    AmadeusW committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    028dd58 View commit details
    Browse the repository at this point in the history

  6. Get context off UI thread, respond to property changed on UI thread

    @AmadeusW
    AmadeusW committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8690915 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. undo unwanted file

    @AmadeusW
    AmadeusW committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    171b026 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Remove CSharpRenameContextHelper; improve the provided context

    @AmadeusW
    AmadeusW committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f4bc198 View commit details
    Browse the repository at this point in the history

  2. modifiers and doc comments

    @AmadeusW
    AmadeusW committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f3c9467 View commit details
    Browse the repository at this point in the history

  3. remove never taken branch

    @AmadeusW
    AmadeusW committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6c06fa3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into dev/amwieczo/getContextForRenamedSymbol

    @AmadeusW
    AmadeusW committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    15d2f2d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Remove IsRenameContextSupported

    @AmadeusW
    AmadeusW committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1faf717 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. PR feedback to move TryGetSurroundingNodeSpanAsync to parent class

    @AmadeusW
    AmadeusW committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c3f3030 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. use CompletesAsyncOperation pattern for SessionPropertyChanged

    @AmadeusW
    AmadeusW committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f14318a View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Create IAsynchronousOperationListener in the constructor

    @AmadeusW
    AmadeusW committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3a33f76 View commit details
    Browse the repository at this point in the history

  2. improve algorithm that provides context snippet

    @AmadeusW
    AmadeusW committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3705723 View commit details
    Browse the repository at this point in the history