Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semantic model keep-alive code in completion #73844

Merged

Commits on Jun 4, 2024

  1. Remove semantic model keep-alive code in completion

    There are quite a few providers that don't request/use the semantic model during their computations, and in the case where they are being used to commit / GetDescription, the model would be obtained/calculated unnecessarilly.
    
    I don't believe the keep alive mechanism here is necessary anymore, as Solution.OnSemanticModelObtained caches the model when it's obtained for the active document in the solution.
    
    Additionally, I switched a couple places in CommitManager to use JTF.Runn instead of WaitAndGetResult
    ToddGrun committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2cfec57 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    547f9dd View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. ci build errors

    ToddGrun committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    68c53b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Configuration menu
    Copy the full SHA
    56a7d82 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    5f036a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    950c60d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    15c7fe2 View commit details
    Browse the repository at this point in the history