Add standard implicit array-to-Span conversions #73538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
commented
May 17, 2024
| @@ -1241,7 +1241,7 @@ private void CheckRestrictedTypeReceiver(BoundExpression expression, CSharpCompi | |||
| ParameterSymbol receiverParameter = method.Parameters.First(); | |||
|
|
|||
| // we will have a different receiver if ReplaceTypeOrValueReceiver has unwrapped TypeOrValue | |||
| if ((object)receiver != receiverArgument) | |||
| if ((object)receiver != methodGroup.Receiver) | |||
There was a problem hiding this comment.
This is to avoid creating the conversion for the extension method receiver twice, avoiding duplicate "missing compiler-required member" diagnostics.
jjonescz
force-pushed
the
FirstClassSpan-02-Conversion
branch
from
e2ab501 to
3fb40ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #73445
This adds only the first two conversions:
The others will be similar, so it will be easier to add them once these are fleshed out. Plus some of the other conversions will need new well-known members and I didn't want to blow up this PR unnecessarily with that.