Move code that retrieves source generators to running in OOP only #72825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 1, 2024
| // We don't have any source generators. Trivially bail out. | ||
| var compilationWithGeneratedFiles = compilationWithoutGeneratedFiles; | ||
| return (compilationWithGeneratedFiles, TextDocumentStates<SourceGeneratedDocumentState>.Empty, generatorInfo.Driver); | ||
| } |
There was a problem hiding this comment.
this code was running on the host side no matter what. we do not want that. that basically loads and caches the SourceGenerators info locally, which means (due to .net fx limitations) that it is effectively fixed. Note: i intend to get rid of ProjectState.SourceGenerators entirely as an api. But this will be a series of small refactorings.
This PR was just an easy example of how to make things better.
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be part of a series of PRs. The main purpose here is to get all calls to ProjectState.SourceGenerators and AnalyzerReference.GetGenerators to run in OOP only. By doing that, we don't even have to load it in VS and we don't have to worry about the .net fx loading semantics for generators (versus the .net core semantics, which can reload generators).
Example of where this matters. Imagine if a user starts with an AnalyzerReference with no source generators in it, but then replaces those (while VS is running) with references that do have source-generators in them. With teh current code, because we loaded the generators within VS, and then checked if we had any, we'll always stay in teh state where we think we have none. However, by moving these loads/checks to OOP, we can realistically reload the reference/generators and then now know that we should be running generators on a particular project.