The RenameFlyout and DisposableToolTip do not use some color tokens correctly #72538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sableToolTip. The change makes those controls use DynamicResources for the color tokens rather than using the VSColorTheme helper or directly querying the Application-level resource dictionary. The change also removes an invalid set of ImageThemingUtilities.ImageBackgroundColor.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
Cosifne
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the incorrect usage of color tokens in the RenameFlyout and DisposableToolTip. The change makes those controls use DynamicResources for the color tokens rather than using the VSColorTheme helper or directly querying the Application-level resource dictionary. The change also removes an invalid set of ImageThemingUtilities.ImageBackgroundColor.
This work is to address issues related to in progress work related to how the Editor handles and supports colors in VS.
These changes are related to this bug:
https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1994113