Do not report unchanged files in workspace-pull diagnostics #72529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
reviewed
Mar 13, 2024
| // | ||
| // Note: if this is a workspace request, we can do nothing, as that will be interpreted by the | ||
| // client as nothing having been changed for that document. | ||
| if (!this.IsWorkspacePullDiagnosticsHandler) |
There was a problem hiding this comment.
Alternative approach - allow CreateUnchangedReport to return a nullable value, and in workspace diagnostics return a null value always.
There was a problem hiding this comment.
fair. it seemed about the same... i'll noodle on it.
dibarbet
approved these changes
Mar 13, 2024
|
I think some tests will need updating as well, e.g. TestWorkspaceDiagnosticsWithChangeInNotReferencedProject |
CyrusNajmabadi
force-pushed
the
workspacePull
branch
from
14bb65f to
ac8e437
Compare
|
Will set to merge once we confirm that VSCode is ok. |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
kayle
reviewed
Mar 13, 2024
| if (!this.IsWorkspacePullDiagnosticsHandler) | ||
| { | ||
| var previousParams = documentToPreviousDiagnosticParams[diagnosticSource.GetId()]; | ||
| progress.Report(CreateUnchangedReport(previousParams.TextDocument, previousParams.PreviousResultId)); |
There was a problem hiding this comment.
Do you have the before/after previousParams.TextDocument int versions to compare too? If the version is different, we need to be careful about skipping.
dibarbet
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak that should ideally save a lot of unnecessary reports being created on the roslyn side and then parsed on the client side.