Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix braces issue fixed locally from last PR but accidentally not pushed before merge #69871

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix braces issue fixed locally from last PR but accidentally not pushed before merge #69871

merged 1 commit into from
Sep 10, 2023

Conversation

ToddGrun
Copy link
Contributor

@ToddGrun ToddGrun commented Sep 9, 2023

No description provided.

@ToddGrun ToddGrun requested a review from a team as a code owner September 9, 2023 13:48
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 9, 2023
davidwengier
davidwengier approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back when I still did Roslyn work, I would always do this, and also instinctively hit the semi-colon key on my keyboard at the end of every line. Fortunately I got into the habit of correcting it before PR 😛

@ToddGrun ToddGrun merged commit d080175 into dotnet:main Sep 10, 2023
@ghost ghost added this to the Next milestone Sep 10, 2023
@allisonchou allisonchou mentioned this pull request Sep 12, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@ToddGrun @davidwengier @Cosifne