Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable test codelens when devkit is enabled #69119

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Disable test codelens when devkit is enabled #69119

merged 2 commits into from
Jul 21, 2023

Conversation

dibarbet
Copy link
Member

No description provided.

@dibarbet dibarbet requested a review from a team as a code owner July 20, 2023 00:02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 20, 2023
@Cosifne
Copy link
Member

Cosifne commented Jul 20, 2023

Seems like it needs client-side change?

@dibarbet
Copy link
Member Author

@Cosifne It does not here. We already know if devkit is running when we start the server

@sharwell
Copy link
Member

sharwell commented Jul 20, 2023 •
edited
Loading

@dibarbet Can you link to the issue this is fixing?

@dibarbet
Copy link
Member Author

@dibarbet Can you link to the this is fixing?

I don't have a specific issue other than the overal 'run tests' issue here - dotnet/vscode-csharp#5719 . This is just a bug I noticed when I was integrating the server bits with the client side changes. Essentially we should only be providing the run/debug test codelens and commands when devkit is not running (since otherwise devkit is responsible for all test functionality).

@runfoapp runfoapp bot mentioned this pull request Jul 10, 2023
Closed
@dibarbet dibarbet requested a review from sharwell July 20, 2023 23:45
@dibarbet dibarbet merged commit fb39a45 into dotnet:main Jul 21, 2023
@dibarbet dibarbet deleted the disable_codelens_devkit branch July 21, 2023 18:20
@ghost ghost added this to the Next milestone Jul 21, 2023
@allisonchou allisonchou mentioned this pull request Jul 24, 2023
Closed
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cosifne Cosifne Cosifne approved these changes

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@dibarbet @Cosifne @sharwell @allisonchou