Fix some null annotations on IDynamicFileInfoProvider #67141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
force-pushed
the
null-annotate-dynamic-files
branch
from
e87b101
to
2a9f4ed
Compare
The only "interesting" annotation here is we're now potentially calling the providers with a null project file path; there's nothing that generally prevented that from happening before, so I'm updating annotations to match.
jasonmalinowski
force-pushed
the
null-annotate-dynamic-files
branch
from
2a9f4ed
to
4740b2e
Compare
jasonmalinowski
commented
Mar 2, 2023
| @@ -17,16 +17,15 @@ internal interface IRazorDynamicFileInfoProvider | |||
| /// <param name="projectId"><see cref="ProjectId"/> this file belongs to</param> | |||
| /// <param name="projectFilePath">full path to project file (ex, csproj)</param> | |||
| /// <param name="filePath">full path to non source file (ex, cshtml)</param> | |||
| /// <returns>null if this provider can't handle the given file</returns> | |||
There was a problem hiding this comment.
So this comment was copied from the IDynamicFileInfoProvider interface which is the regular one -- however the wrapper never handled a null return from Razor, so this wasn't in practice the contract being enforced. I've updated this to match code behavior.
arkalyanms
approved these changes
Mar 2, 2023
CyrusNajmabadi
approved these changes
Mar 2, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only "interesting" annotation here is we're now potentially calling the providers with a null project file path; there's nothing that generally prevented that from happening before, so I'm updating annotations to match.